ghc: apply a patch to fix common gold linker problem #27584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenkozar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill, @peti and @3noch to be potential reviewers. |
|
LGTM but I'm no expert here :) |
|
Yes, this looks right to me as well. |
bgamari
reviewed
Jul 23, 2017
| @@ -19,7 +19,7 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1c8qc4fhkycynk4g1f9hvk53dj6a1vvqi6bklqznns6hw59m8qhi"; | |||
| }; | |||
|
|
|||
| patches = [] | |||
| patches = [ ./ghc-gold-liner.patch ] | |||
There was a problem hiding this comment.
Should this be gold-linker or is this a clever pun?
It would otherwise result into undefined referenecs for some functions in the base when using the gold linker: error: undefined reference to 'sqrt' Fixes haskell/double-conversion#17 Previously ghc option -optl=-lm was used for packages depending on such functions, but that could result into fatal error: cannot mix -r with dynamic object /nix/store/7crrmih8c52r8fbnqb933dxrsp44md93-glibc-2.25/lib/libm.so.6 in some situations like profiling builds. Patch was prepared by Michael Bishop and Niklas Hambüchen
|
Tracked as GHC #14022. Patch uploaded as D3780. Thanks for reporting this! |
domenkozar
force-pushed
the
ghc-gold-linking
branch
from
62781b3 to
1715844
Compare
shlevy
approved these changes
Jul 23, 2017
|
@peti should we merge this or are you going to incorporate into your fork? |
|
I've added it to |
|
@peti could you also backport to 17.03? Thank you! |
2 tasks
peti
pushed a commit
that referenced
this pull request
Jul 26, 2017
It would otherwise result into undefined referenecs for some functions in the base when using the gold linker: error: undefined reference to 'sqrt' Fixes haskell/double-conversion#17 Previously ghc option -optl=-lm was used for packages depending on such functions, but that could result into fatal error: cannot mix -r with dynamic object /nix/store/7crrmih8c52r8fbnqb933dxrsp44md93-glibc-2.25/lib/libm.so.6 in some situations like profiling builds. Patch was prepared by Michael Bishop and Niklas Hambüchen. Closes #27584. (cherry picked from commit aafe3d2)
|
@peti I don't want to hit "Delete branch" for you, in case you need the branch still. If not, could you? :D |
|
For the record, GHC upstream is taking a slightly different tack on this: https://phabricator.haskell.org/D3787. |
domenkozar
added a commit
that referenced
this pull request
Aug 6, 2017
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
It would otherwise result into undefined referenecs for some functions in the base when using the gold linker: error: undefined reference to 'sqrt' Fixes haskell/double-conversion#17 Previously ghc option -optl=-lm was used for packages depending on such functions, but that could result into fatal error: cannot mix -r with dynamic object /nix/store/7crrmih8c52r8fbnqb933dxrsp44md93-glibc-2.25/lib/libm.so.6 in some situations like profiling builds. Patch was prepared by Michael Bishop and Niklas Hambüchen. Closes NixOS#27584. (cherry picked from commit aafe3d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would otherwise result into undefined referenecs for some functions
in the base when using the gold linker:
error: undefined reference to 'sqrt'
Fixes haskell/double-conversion#17
Previously ghc option -optl=-lm was used for packages depending on
such functions, but that could result into
fatal error: cannot mix -r with dynamic object /nix/store/7crrmih8c52r8fbnqb933dxrsp44md93-glibc-2.25/lib/libm.so.6
in some situations like profiling builds.
Patch was prepared by Michael Bishop and Niklas Hambüchen
NOTE: this hasn't been tested on macOS yet.
cc @peti